Comments on: Yet another data validation approach

By: Xadio

Xadio — Sun, 23 Jul 2006 09:24:21 +0000

I modified Cakebaker’s Advanced Validation so that I could reduce the number of validating methods and increase reuse through the allowance of parameters. (ie one unique method that checks unique of username and email dynamically) You can find it on the CakePHP Wiki. http://wiki.cakephp.org/tutorials:advanced_validation:advance_validation_with_parameters#advanced_validation_with_parameters

By: binoy

binoy — Tue, 04 Jul 2006 15:59:16 +0000

Hi,
I am using Cake 1.0.1.2708 and I am using this advanced validation technique. It is working fine.

But I want to send some parameters to the custom function. What I need to change in the code. Any help ?

By: cakebaker

cakebaker — Wed, 28 Jun 2006 07:57:47 +0000

@olegs: I have added this functionality to fix the following bug: https://trac.cakephp.org/ticket/781

By: olegs

olegs — Sat, 24 Jun 2006 21:45:36 +0000

Hello,
Why do you need to merge old and new data ?

if (isset($this->data))
{
$data = array_merge($data, $this->data);
}
(I’m referring here to the function for Cake>1.0.1.2708. In cake original invalidFields() function there is no such behaviour).

By: cake baker » Upgrading to version 1.0 III

cake baker » Upgrading to version 1.0 III — Thu, 18 May 2006 09:36:14 +0000

[...] Update (2006-05-06): It transpired that the bug was in the advanced validation approach I use, and not in Model->save(). [...]

By: cakebaker

cakebaker — Sun, 07 May 2006 10:11:07 +0000

@Brandon Pearce: Interesting idea. I am not aware of such a helper, so you have to write it yourself. I think it is not always possible to get the label text from the model (e.g. if the language of the user interface is not english), so this parameter should be at least optional.

I think the reason why there is no generatePasswordDiv() function is that it is not possible to automatically create such fields with scaffolding. But you can open a ticket with such a feature request.

By: Brandon Pearce

Brandon Pearce — Sat, 06 May 2006 22:48:08 +0000

I think this is the greatest thing! Makes form validation so much easier. The only thing I see lacking in Cake now in regards to validation is the Form Helper. Wouldn’t it be nice if the Form Helper could tell by looking at the model whether a field is required, and what the error message should be, rather than me having to pass in those values? It would be great to get a form looking like this:
http://kalsey.com/simplified/form_errors/index.html

So, instead of this:
generateInputDiv(‘User/first_name’, ‘First Name’, true, ‘Please enter your first name’)?>

Just take all the validation from the model, so all you have to type is:
generateInputDiv(‘User/first_name’)?>

And it will generate the appropriate error messages, as well as the label (or prompt – just humanize first_name). Wouldn’t that save a lot of typing – and there’s no reason to type the validation messages in the model AND the view.
(Also, why is there no generatePasswordDiv() function in the form helper?)

Is this already done somewhere and currently possible with Cake or would someone have to write another helper for this? Any thoughts?

By: cakebaker

cakebaker — Sat, 06 May 2006 08:49:06 +0000

@Zachary Naiman: Thanks for your comment. I had the same problem, but “solved” it in a different way. I thought it was a bug in Model->save() and fixed that “bug” ;-) I applied a bugfix and will modify this post and the wiki entry in a moment.

Thanks, and happy baking :)

By: Zachary Naiman

Zachary Naiman — Fri, 05 May 2006 16:43:38 +0000

My colleagues and I are new to CAKE, and after a couple weeks of evaluating it versus other products (mainly symphony), we decided to use CAKE for all future php development in our office. Shortly after we tried to implement this validation method as CAKE’s current validation functions don’t allow for creating multiple validation rules. As with chris, we followed the tutorial, but invalid data was still being saved to the database and no messages were reported.

What we’ve figured out so far is that the very first “if” statement in the AppModel “invalidFields” function was being interpreted as true because $this->validationErrors is an (enpty) array. So our quick way around this, which seems to make things work OK, is to either change the condition on that first if statement (put an exclamation point before is_array($this->validationErrors)), or (what seems like a better idea) to put this code before the if statment: if (empty($this->validationErrors)){unset($this->validationErrors);$this->validationErrors=”";}

Since we’re really new to CAKE, we’re not sure what the implications of this strategy will be, but we’d love some feedback.

Also, thanks to cakebaker and the whole CAKE community.

By: kain

kain — Thu, 20 Apr 2006 03:43:10 +0000

I think there is a problem if we apply this method to a Model/field like User/name.. data cannot be validated.

‘name’ => array(array(VALID_NOT_EMPTY))

I’m using tagerrormsg way

works with
var $validate = array(‘name’ => VALID_NOT_EMPTY);
as normal but we cannot use this string with this method.